Skip to content

Develop - #136

Merged
ucswift merged 3 commits into
masterfrom
develop
Aug 20, 2026
Merged

ucswift merged 3 commits into
masterfrom
develop

Conversation

@ucswift

@ucswift ucswift commented Aug 20, 2026 •

Copy link
Copy Markdown
Member

Summary

This PR improves push notification behavior, map icon rendering, and UTC time formatting consistency across platforms.

What changed

Push notifications

  • Enabled push notification initialization in the main app layout so notification handling is now active.
  • Improved push notification parsing so notifications can correctly read eventCode from both standard payload data and iOS raw trigger payloads.
  • Added direct deep-link handling for:
    • chat notifications
    • call notifications
  • Added fallback behavior so if a push deep-link cannot complete, the notification modal is shown instead of leaving the user on an unrelated screen.
  • Added duplicate tap protection so the same notification response is not handled twice.
  • Expanded notification parsing to support:
    • legacy event codes without a colon, such as C1234
    • uppercase chat/group prefixes
    • IDs that may contain colons after the first separator
  • Added route ID safety validation and applied it consistently to both deep-link handling and the notification modal so unsafe IDs do not produce navigable routes.
  • Updated tests to cover iOS payload extraction, chat/call deep-link behavior, fallback handling, deduplication, and unsafe route IDs.

Notification modal

  • The “View call” action is now only shown and executed when the call ID is considered safe for routing.
  • Added tests to confirm unsafe call IDs do not show the call action.

Map icons

  • Registered the bundled map-icons font at app startup using expo-font.
  • Updated native and web marker rendering to rely on the bundled map-icons font instead of injecting web font-face definitions from server-hosted files.
  • Expanded the map icon unicode mapping to align with the bundled map icon font and support a much broader set of marker icon types.

Time ago formatting

  • Fixed getTimeAgoUtc so timestamps with explicit timezone information (Z or offsets) are treated as exact instants and no longer get an extra legacy timezone adjustment.
  • Preserved compatibility for older zone-less UTC strings by keeping the offset-based comparison only for that legacy format.
  • Added tests covering zoned strings, zone-less legacy strings, Date objects, epoch values, and empty input.

@Resgrid-Bot

Resgrid-Bot commented Aug 20, 2026 •

Copy link
Copy Markdown

Code Review Could Not Complete ⚠️

The review failed before suggestions could be generated.

Reason: Rate limit reached on the provider (openai). Try again in a few minutes.

After fixing the issue, comment @kody review on this PR to re-run the review.

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Validate Business Logic: Ask Kody to validate your code against business rules by adding a comment with the @kody -v business-logic command.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug ✅
Performance ✅
Security ✅
Business Logic ❌

Access your configuration settings here.

​

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your current included review allowance is based on your included PR review attempts over the past 7 days.

Next review available in: 59 minutes

Limit details: You’ve used the included review currently available. Your 61 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fe42f56f-5d1a-439c-8bbd-28bcf9f822ec

📥 Commits

Reviewing files that changed from the base of the PR and between cc44332 and a999aab.

⛔ Files ignored due to path filters (1)
  • assets/fonts/map-icons.ttf is excluded by !**/*.ttf
📒 Files selected for processing (13)
  • src/app/(app)/_layout.tsx
  • src/app/_layout.tsx
  • src/components/maps/pin-marker.tsx
  • src/components/push-notification/__tests__/push-notification-modal.test.tsx
  • src/components/push-notification/push-notification-modal.tsx
  • src/lib/__tests__/get-time-ago-utc.test.ts
  • src/lib/map-markers-web.ts
  • src/lib/map-markers.ts
  • src/lib/utils.ts
  • src/services/__tests__/push-notification-chat-deeplink.test.ts
  • src/services/push-notification.ts
  • src/stores/push-notification/__tests__/store.test.ts
  • src/stores/push-notification/store.ts

Comment @coderabbitai help to get the list of available commands.

@ucswift

ucswift commented Aug 20, 2026

Copy link
Copy Markdown
Member Author

Approve

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is approved.

@ucswift
ucswift merged commit 7b331b9 into master Aug 20, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants